fix(db): chunk deleteResolvedReferences IN-list under the SQLite param limit (#1001)#1023
Merged
Merged
Conversation
…m limit (#1001) deleteResolvedReferences bound every id into a single unbounded `IN (...)`, so a list longer than SQLITE_MAX_VARIABLE_NUMBER (32766 on the bundled node:sqlite) threw "too many SQL variables" — the one IN-list in queries.ts that #540 missed. It's reachable only through the exported QueryBuilder (library use): the internal resolution path uses deleteSpecificResolvedReferences, which binds per-row and is immune, so the CLI/MCP indexing pipeline was never affected. Wrap it in the same SQLITE_PARAM_CHUNK_SIZE loop every sibling query uses, and add a regression test (33k ids, past the real 32766 ceiling) that throws without the fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1001.
What
QueryBuilder.deleteResolvedReferences()bound every id into a single unboundedIN (...), so a list longer thanSQLITE_MAX_VARIABLE_NUMBERthrew "too many SQL variables" — the one IN-list inqueries.tsthat #540 missed. Wrapped it in the sameSQLITE_PARAM_CHUNK_SIZEloop every sibling query already uses.Scope correction vs. the issue
The report is right that the method is unchunked, but two of its claims don't hold up — and the real exposure is narrower:
deleteResolvedReferenceshas zero callers in all of git history. Resolution usesdeleteSpecificResolvedReferences, which binds per-row in a loop (no IN-list) and is immune — deliberately so (it's keyed onreferenceNameto avoid the gin re-resolve runaway). So the CLI/MCP indexing pipeline was never affected.SQLITE_MAX_VARIABLE_NUMBER; probing the bundlednode:sqliteconfirms 32766 OK / 32767 throws. The issue's assumed 999 threshold doesn't reproduce.The method is reachable through the exported
QueryBuilder(library use), so this is a real latent bug worth hardening — chunked rather than deleted, since dropping a public method is a breaking change for a one-line fix.Test
Regression test added next to the existing
getNodesByIdschunking test, using 33,000 ids (past the real 32766 ceiling). Verified it throwstoo many SQL variableswithout the fix and passes with it. All 13db-perftests green.🤖 Generated with Claude Code