Bump Staticcheck to 2026.1 - #38
Conversation
Regenerates docs/patterns.json and docs/description/*.md via sbt doc-generator/run against staticcheck 2026.1. No rule IDs were added, removed, or renamed in 2025.1.1 -> 2026.1 (only wording tweaks and behavioral fixes per upstream release notes), so no DocGenerator.scala rule list changes were needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
The PR updates Staticcheck documentation to version 2026.1 and has been rated as up to standards by Codacy. However, there is a critical gap: the build.sbt file, which should contain the actual tool version bump, is missing from the file list despite being a primary acceptance criterion. Additionally, there are no automated tests present to verify that the engine reports the correct version or that the documentation metadata remains synchronized with the build configuration.
Test suggestions
- Verify that the engine correctly identifies its version as 2026.1 during execution.
- Ensure
docs/patterns.jsonversion field is kept in sync with the build file automatically.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the engine correctly identifies its version as 2026.1 during execution.
2. Ensure `docs/patterns.json` version field is kept in sync with the build file automatically.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
| It is virtually never correct to delete system directories such as | ||
| /tmp or the user's home directory. However, it can be fairly easy to | ||
| do by mistake, for example by mistakingly using os.TempDir instead | ||
| do by mistake, for example by mistakenly using os.TempDir instead |
There was a problem hiding this comment.
⚪ LOW RISK
Nitpick: This sentence is redundant as it uses both 'by mistake' and 'mistakenly' to describe the same action. Removing the second instance improves clarity.
| do by mistake, for example by mistakenly using os.TempDir instead | |
| do by mistake, for example by using os.TempDir instead |
Summary
2025.1.1to2026.1(val staticcheckVersioninbuild.sbt).docs/patterns.json(version field) and 4docs/description/*.mdfiles viasbt doc-generator/run, run against a locally-installedstaticcheck 2026.1 (v0.7.0).ruleslist inDocGenerator.scala: per upstream's 2026.1 release notes, no checks were added, removed, or renamed between 2025.1.1 and 2026.1 — only wording tweaks (e.g.interface{}→any) and behavioral fixes to existing checks (SA1026, SA4000, SA4003, SA4030, SA5008, SA5010, ST1003, ST1019, QF1002, QF1008, QF1012).codacy-engine-scala-seed/scala-xml/ujson/scalatest/ CircleCI orbs / Alpine base image — out of scope for this pure Staticcheck bump, and I couldn't reliably verify newer published versions for those from this environment. Flagging in case a maintainer wants a follow-up.Validation (local)
sbt scalafmt::test test:scalafmt::test sbt:scalafmt::test test:compile— passsbt test— 2/2 tests passsbt assembly— fat-jar builds successfullysbt nativeImage— fails locally withDARWIN does not support building static executable images.This is a pre-existing macOS/Darwin limitation of the--staticnative-image flag (unrelated to this change); CI builds this via a Linux executor where it's expected to succeed.docker build -t codacy-staticcheck .— builds successfullyTest plan
check_fmt_and_compile,test,package_artifacts,docker_publish_local,plugins_test)