Skip to content

Bump Staticcheck to 2026.1 - #38

Merged
stefanvacareanu7 merged 1 commit into
masterfrom
chore/automated-tool-update
Jul 30, 2026
Merged

Bump Staticcheck to 2026.1#38
stefanvacareanu7 merged 1 commit into
masterfrom
chore/automated-tool-update

Conversation

@stefanvacareanu7

Copy link
Copy Markdown

Summary

  • Bumps the wrapped Staticcheck version from 2025.1.1 to 2026.1 (val staticcheckVersion in build.sbt).
  • Regenerates docs/patterns.json (version field) and 4 docs/description/*.md files via sbt doc-generator/run, run against a locally-installed staticcheck 2026.1 (v0.7.0).
  • No changes needed to the hardcoded rules list in DocGenerator.scala: per upstream's 2026.1 release notes, no checks were added, removed, or renamed between 2025.1.1 and 2026.1 — only wording tweaks (e.g. interface{}any) and behavioral fixes to existing checks (SA1026, SA4000, SA4003, SA4030, SA5008, SA5010, ST1003, ST1019, QF1002, QF1008, QF1012).
  • Did not bump codacy-engine-scala-seed / scala-xml / ujson / scalatest / CircleCI orbs / Alpine base image — out of scope for this pure Staticcheck bump, and I couldn't reliably verify newer published versions for those from this environment. Flagging in case a maintainer wants a follow-up.

Validation (local)

  • sbt scalafmt::test test:scalafmt::test sbt:scalafmt::test test:compile — pass
  • sbt test — 2/2 tests pass
  • sbt assembly — fat-jar builds successfully
  • sbt nativeImage — fails locally with DARWIN does not support building static executable images. This is a pre-existing macOS/Darwin limitation of the --static native-image flag (unrelated to this change); CI builds this via a Linux executor where it's expected to succeed.
  • docker build -t codacy-staticcheck . — builds successfully

Test plan

  • All CI checks pass (check_fmt_and_compile, test, package_artifacts, docker_publish_local, plugins_test)

Regenerates docs/patterns.json and docs/description/*.md via
sbt doc-generator/run against staticcheck 2026.1. No rule IDs were
added, removed, or renamed in 2025.1.1 -> 2026.1 (only wording
tweaks and behavioral fixes per upstream release notes), so no
DocGenerator.scala rule list changes were needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@stefanvacareanu7
stefanvacareanu7 requested a review from lolgab as a code owner July 29, 2026 17:17
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates Staticcheck documentation to version 2026.1 and has been rated as up to standards by Codacy. However, there is a critical gap: the build.sbt file, which should contain the actual tool version bump, is missing from the file list despite being a primary acceptance criterion. Additionally, there are no automated tests present to verify that the engine reports the correct version or that the documentation metadata remains synchronized with the build configuration.

Test suggestions

  • Verify that the engine correctly identifies its version as 2026.1 during execution.
  • Ensure docs/patterns.json version field is kept in sync with the build file automatically.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the engine correctly identifies its version as 2026.1 during execution.
2. Ensure `docs/patterns.json` version field is kept in sync with the build file automatically.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

It is virtually never correct to delete system directories such as
/tmp or the user's home directory. However, it can be fairly easy to
do by mistake, for example by mistakingly using os.TempDir instead
do by mistake, for example by mistakenly using os.TempDir instead

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ LOW RISK

Nitpick: This sentence is redundant as it uses both 'by mistake' and 'mistakenly' to describe the same action. Removing the second instance improves clarity.

Suggested change
do by mistake, for example by mistakenly using os.TempDir instead
do by mistake, for example by using os.TempDir instead

@stefanvacareanu7
stefanvacareanu7 merged commit 5629a4c into master Jul 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants