build(deps): bump graphql from 2.6.5 to 2.6.6 - #1014
Conversation
Bumps [graphql](https://github.com/rmosolgo/graphql-ruby) from 2.6.5 to 2.6.6. - [Release notes](https://github.com/rmosolgo/graphql-ruby/releases) - [Changelog](https://github.com/rmosolgo/graphql-ruby/blob/master/CHANGELOG.md) - [Commits](rmosolgo/graphql-ruby@v2.6.5...v2.6.6) --- updated-dependencies: - dependency-name: graphql dependency-version: 2.6.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the graphql gem from version 2.6.5 to 2.6.6. This is a security-focused update addressing GHSA-j7xr-4g94-r9h3 (Execution::Next vulnerability) and including a fix for query token limits in Schema.validate.
Codacy results indicate the project is up to standards. There are no logic or security flaws identified in the Gemfile.lock update that should prevent merging. However, manual or automated verification of the specific execution scenarios affected by the patch is recommended as part of the test plan.
Test suggestions
- Verify that GraphQL queries still execute correctly following the security patch in Execution::Next.
- Confirm that Schema.validate correctly applies query token limits as per the new fix.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that GraphQL queries still execute correctly following the security patch in Execution::Next.
2. Confirm that Schema.validate correctly applies query token limits as per the new fix.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Bumps graphql from 2.6.5 to 2.6.6.
Changelog
Sourced from graphql's changelog.
Commits
95489472.6.6011203dMerge pull request #5673 from ydah/fix-operation-directive-finalizerdd6f3f3Merge pull request #5672 from rmosolgo/async-dataloader-error-handlingac63800Merge commit from fork741e379Correctly handle UnauthorizedErrors raised by Resolvers in Execution::Nexteb230f8Move spawn_tasks back to a method to preserve reference to pending_work8e8bf89Use sequential calls instead of yield with next_lazies2fe9a62Remove needless method726ff88Clean up some internal APIs5bfae85Skip lintDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)