build(deps): bump github.com/PuerkitoBio/goquery from 1.10.3 to 1.12.0 - #123
Conversation
Bumps [github.com/PuerkitoBio/goquery](https://github.com/PuerkitoBio/goquery) from 1.10.3 to 1.12.0. - [Release notes](https://github.com/PuerkitoBio/goquery/releases) - [Commits](PuerkitoBio/goquery@v1.10.3...v1.12.0) --- updated-dependencies: - dependency-name: github.com/PuerkitoBio/goquery dependency-version: 1.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 minor 8 high 1 critical 16 medium |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Pull Request Overview
This PR is currently not up to standards and should not be merged in its current state. The primary blockers are the use of invalid versions for both the Go runtime and the goquery dependency. Go 1.25.0 is an unreleased version, and github.com/PuerkitoBio/goquery v1.12.0 does not exist in the public registry; these will cause immediate build and dependency resolution failures.
From a security perspective, the Go 1.25.0 version introduces 26 vulnerabilities, including critical issues like CVE-2025-68121 in crypto/tls (allowing MitM attacks) and several DoS-related vulnerabilities (CVE-2025-58183, CVE-2025-61726). The PR also removes the toolchain directive without explanation, which may impact build reproducibility.
About this PR
- The Go version was bumped to 1.25.0. Ensure that the project's CI/CD pipeline, development environments, and production runners are updated to support this version. Additionally, the 'toolchain' directive was removed from go.mod; verify if this was intentional or an accidental side effect of the update command.
Test suggestions
- Verify that the project compiles successfully using Go 1.25.0
- Run existing regression tests to ensure compatibility with goquery v1.12.0
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that the project compiles successfully using Go 1.25.0
2. Run existing regression tests to ensure compatibility with goquery v1.12.0
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
|
|
||
| require ( | ||
| github.com/PuerkitoBio/goquery v1.10.3 | ||
| github.com/PuerkitoBio/goquery v1.12.0 |
There was a problem hiding this comment.
🔴 HIGH RISK
The version v1.12.0 for github.com/PuerkitoBio/goquery is invalid and does not exist in the public Go registry. This will cause go mod download to fail. Please use a valid version (the current latest is v1.10.1).
| go 1.24.0 | ||
|
|
||
| toolchain go1.24.7 | ||
| go 1.25.0 |
There was a problem hiding this comment.
🔴 HIGH RISK
The Go version has been bumped to 1.25.0, which is currently unreleased (the current stable release is 1.24). Additionally, this version introduces multiple severe vulnerabilities in the standard library, such as CVE-2025-68121 (crypto/tls) which can lead to incorrect certificate validation, and several high-severity DoS issues (CVE-2025-58183, CVE-2025-61726). Please revert to a stable and secure Go version.
Possible fix:
| go 1.25.0 | |
| go 1.25.9 |
Bumps github.com/PuerkitoBio/goquery from 1.10.3 to 1.12.0.
Release notes
Sourced from github.com/PuerkitoBio/goquery's releases.
Commits
401642bUpdate readme to prepare for 1.12 releaseafd9326Merge pull request #540 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...f799f78Bump golang.org/x/net from 0.50.0 to 0.52.0805d7b1Update CI to 1.25 and 1.267dc7e64Merge pull request #538 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...3020ebbBump golang.org/x/net from 0.49.0 to 0.50.0ee4bcdbMerge pull request #537 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...f3bc303Bump golang.org/x/net from 0.48.0 to 0.49.00f22828Merge pull request #536 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...68de6a1Bump golang.org/x/net from 0.47.0 to 0.48.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)