chore: update tested node versions to 14, 16, and 18 - #347
Merged
Conversation
Pull Request Test Coverage Report for Build 2361219349
💛 - Coveralls |
Member
Author
|
@Apollon77 Hmm, seems like Node 18 causes some problems. I think there was a multicast-related API change that causes that? |
Collaborator
|
puuhh ... ist it that "network family parameter change"? Will be reverted in 18.2 as it seems |
Member
Author
Oh, you mean this one, right? nodejs/node#41431 (comment) |
Collaborator
|
yes, should be reverted in node.js 18.2 |
Collaborator
|
nope ... not fixed by 18.2 |
Member
Author
I think the number of errors reduced from 10 to 4, though, so we're at least halfway there ;) |
Member
Author
|
The latest version of Node 18 seems to have solved the issue :) So I would merge this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.