Log DB query request metrics#4442
Merged
Merged
Conversation
philippthun
force-pushed
the
codex/add-database-query-metrics-and-logging
branch
from
6006476 to
e30e7ed
Compare
philippthun
force-pushed
the
codex/add-database-query-metrics-and-logging
branch
3 times, most recently
from
fed7ff1 to
a4fdbd8
Compare
philippthun
force-pushed
the
codex/add-database-query-metrics-and-logging
branch
3 times, most recently
from
6bd6c97 to
aae3c62
Compare
- number of queries per request - accumulated query time
philippthun
force-pushed
the
codex/add-database-query-metrics-and-logging
branch
from
aae3c62 to
9dcd69e
Compare
jochenehret
requested changes
Aug 5, 2025
Contributor
There was a problem hiding this comment.
Works fine if log_db_queries is true. If it is false, the keys total_db_query_time_in_ms and db_query_count are logged with constant values 0. time_taken_in_ms is correctly logged. The db_query keys should only be logged if log_db_queries is true.
* if log_db_queries is falses, the two new fields would be logged but always with "0" as value
jochenehret
approved these changes
Aug 7, 2025
stephanme
approved these changes
Aug 7, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 7, 2025
Changes in cloud_controller_ng:
- Log DB query request metrics
PR: cloudfoundry/cloud_controller_ng#4442
Author: Philipp Thun <philipp.thun@sap.com>
Author: Jochen Ehret <jochen.ehret@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request_metricsmiddleware (the first one)request_logsmiddlewareI have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests