Skip to content

[build] Split pyodide repos from Python deps file - #6940

Open
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/python-deps
Open

[build] Split pyodide repos from Python deps file#6940
ryanking13 wants to merge 1 commit into
mainfrom
gyeongjae/python-deps

Conversation

@ryanking13

Copy link
Copy Markdown
Contributor

This is a QOL improvements that splits out the Pyodide dependencies from the python.MODULE.bazel file into pyodide.MODULE.bazel. This allows our internal repo to symlink this file instead of updating two different files at the same time when we e.g. update Pyodide bundles or memory snapshots.

@ask-bonk

ask-bonk Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

The use_repo lists match exactly. This is a clean, mechanical split. The changes are:

  1. MODULE.bazel: Adds include("//build/deps:pyodide.MODULE.bazel") after the python.MODULE.bazel include.
  2. build/deps/pyodide.MODULE.bazel (new): Contains the use_extension + use_repo block that was previously in python.MODULE.bazel, pointing at the new pyodide.bzl extension.
  3. build/deps/pyodide.bzl (new): Contains the module_extension definition that was previously at the bottom of dep_pyodide.bzl, loading dep_pyodide from the existing file.
  4. build/deps/dep_pyodide.bzl: Removes the old module_extension definition (moved to pyodide.bzl).
  5. build/deps/python.MODULE.bazel: Removes the pyodide use_extension + use_repo block (moved to pyodide.MODULE.bazel).

No logic changed. The dep_pyodide() function is untouched. The repo list is identical. The refactoring is purely organizational.

LGTM

github run

@dom96 dom96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! I love it. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants