[Docs] Update out of date astro deploy guide - #5730
Merged
deadlypants1973 merged 7 commits intoSep 20, 2022
Merged
Conversation
Contributor
Author
|
cc @sarah11918 |
sarah11918
reviewed
Sep 2, 2022
sarah11918
left a comment
sarah11918
left a comment
Contributor
There was a problem hiding this comment.
Thanks @mohammed-elhaouari for doing this on behalf of Astro Docs!
I've left some suggestions that I think (hope!) Cloudflare would be OK with! But obviously, it's their call.
If it's helpful to any reviewers, we have recently updated our own "Deploy to Cloudflare" docs based on user feedback, and you can see what we've got there: https://docs.astro.build/en/guides/deploy/cloudflare/
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
mhdcodes
changed the title
Member
|
Hey, We're currently tracking this ourselves here: #5499 Hoping to ship it on Monday when our PCX reviewer Kate is back in the office. |
deadlypants1973
approved these changes
Sep 20, 2022
PCX review
deadlypants1973
approved these changes
Sep 20, 2022
This was referenced Sep 20, 2022
WalshyDev
pushed a commit
that referenced
this pull request
Oct 5, 2022
* Update out of date astro docs * Update install line * Update content/pages/framework-guides/astro.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update content/pages/framework-guides/astro.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update content/pages/framework-guides/astro.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update content/pages/framework-guides/astro.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Apply suggestions from code review PCX review Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Kate Tungusova <70746074+deadlypants1973@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes