Skip to content

Add hidden Basic auth defaults for git tools - #1431

Merged
threepointone merged 1 commit into
mainfrom
support-gittools-basic-auth
Apr 30, 2026
Merged

Add hidden Basic auth defaults for git tools#1431
threepointone merged 1 commit into
mainfrom
support-gittools-basic-auth

Conversation

@threepointone

@threepointone threepointone commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds gitTools(workspace, { auth: { username, password } }) and gitToolsFromFs(..., { auth }) for hidden default Basic auth credentials.
  • Preserves existing hidden token behavior while making precedence explicit: direct tool-call auth, default Basic auth, then default token.
  • Keeps injected credentials out of model-visible tool declarations/descriptions and adds regression coverage that provider results do not echo hidden credentials.
  • Documents the Basic auth configuration path and adds a patch changeset for @cloudflare/shell.

Test plan

  • npm run format
  • npm run test -- src/tests/git.test.ts from packages/shell
  • npm run build from packages/shell
  • npm run check

Fixes #1427

Made with Cursor


Open in Devin Review

@changeset-bot

changeset-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6983364

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/shell Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Apr 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

agents

npm i https://pkg.pr.new/agents@1431

@cloudflare/ai-chat

npm i https://pkg.pr.new/@cloudflare/ai-chat@1431

@cloudflare/codemode

npm i https://pkg.pr.new/@cloudflare/codemode@1431

hono-agents

npm i https://pkg.pr.new/hono-agents@1431

@cloudflare/shell

npm i https://pkg.pr.new/@cloudflare/shell@1431

@cloudflare/think

npm i https://pkg.pr.new/@cloudflare/think@1431

@cloudflare/voice

npm i https://pkg.pr.new/@cloudflare/voice@1431

@cloudflare/worker-bundler

npm i https://pkg.pr.new/@cloudflare/worker-bundler@1431

commit: 6983364

@threepointone
threepointone merged commit e430847 into main Apr 30, 2026
2 checks passed
@threepointone
threepointone deleted the support-gittools-basic-auth branch April 30, 2026 20:01
@github-actions github-actions Bot mentioned this pull request Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support hidden default basic auth in @cloudflare/shell gitTools

1 participant