Skip to content

test(ui): Drop low-signal flaky SignUpStart unsafeMetadata test#8529

Merged
jacekradko merged 2 commits into
mainfrom
rob/unsafemetadata-flaky-test
May 12, 2026
Merged

test(ui): Drop low-signal flaky SignUpStart unsafeMetadata test#8529
jacekradko merged 2 commits into
mainfrom
rob/unsafemetadata-flaky-test

Conversation

@wobsoriano
Copy link
Copy Markdown
Member

Description

Follow-up to #8500 and #8504.

The error fixed in #8500 only surfaced in Sentry and was never reported as a user-facing runtime issue. The fix was straightforward, since it only required adding the missing methods to the synthetic unsafeMetadata field in SignUpStart.

The unit test added for that path is flaky, even after #8504, so this PR removes it to avoid continued CI noise.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel
Copy link
Copy Markdown

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 12, 2026 2:19pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 12, 2026

🦋 Changeset detected

Latest commit: 58f8ab6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the ui label May 12, 2026
@wobsoriano wobsoriano changed the title test(ui): Remove flaky unsafeMetadata test test(ui): Remove flaky SignUpStart unsafeMetadata regression test May 12, 2026
@wobsoriano wobsoriano changed the title test(ui): Remove flaky SignUpStart unsafeMetadata regression test test(ui): Drop low-signal flaky SignUpStart unsafeMetadata test May 12, 2026
@wobsoriano wobsoriano requested a review from jacekradko May 12, 2026 14:20
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes the unsafeMetadata test suite from SignUpStart.test.tsx and documents the change via a new changeset entry. The deleted test suite contained 53 lines verifying that signUp.create rejection with a ClerkAPIResponseError does not surface as an unhandled rejection when unsafeMetadata is provided. A .changeset/famous-bats-tan.md file was added to track this change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly relates to the changeset by explaining the context of the removed test, its flakiness, and references to prior PRs that provide additional context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main change: removal of a flaky test for the SignUpStart unsafeMetadata feature. It is specific, concise, and follows conventional commit format.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 12, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8529

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8529

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8529

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8529

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8529

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8529

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8529

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8529

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8529

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8529

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8529

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8529

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8529

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8529

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8529

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8529

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8529

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8529

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8529

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8529

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8529

commit: 58f8ab6

@jacekradko jacekradko merged commit a233ddb into main May 12, 2026
43 of 45 checks passed
@jacekradko jacekradko deleted the rob/unsafemetadata-flaky-test branch May 12, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants