refactor(react): unify headless init with replayInterceptedInvocations#8011
Merged
chriscanin merged 1 commit intoMar 9, 2026
Conversation
…ocations Remove the duplicate finishInit() from loadHeadlessClerk and use the shared replayInterceptedInvocations path instead. This ensures both browser and headless paths share the same post-load wiring logic, including status/queryClientStatus listener replay that was previously missing from the headless path. The manual state emission workaround in finishInit is no longer needed since replayInterceptedInvocations properly wires up addListener which handles state propagation through clerk-js.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
9 tasks
chriscanin
merged commit 825d79f
into
chris/mobile-405-react-native-components-release
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finishInit()fromloadHeadlessClerkand uses the sharedreplayInterceptedInvocationspath instead#initializedfieldThis addresses @brkalow's feedback to separate "how to get a Clerk instance" (bring your own constructor vs inject scripts) from "what to do after it's loaded" (shared wiring logic).
Before:
loadHeadlessClerkhad its ownfinishInit()that duplicated parts ofreplayInterceptedInvocationsbut was missing status/queryClientStatus listener replay.After:
loadHeadlessClerkonly handles Clerk construction +clerk.load(), then hands off to the sharedreplayInterceptedInvocationspath — same as the browser flow.Test plan