Skip to content

fix(pg-adapters): correct the live-probe psql flag (-tArc -> -tAc) - #138

Merged
groganz merged 1 commit into
mainfrom
lane/pg-adapter-fix
Jul 13, 2026
Merged

fix(pg-adapters): correct the live-probe psql flag (-tArc -> -tAc)#138
groganz merged 1 commit into
mainfrom
lane/pg-adapter-fix

Conversation

@groganz

@groganz groganz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Corrects an invalid psql flag in the live version probe shipped in #137 (cli#129). -tArc (the -r is not a psql option) made SHOW server_version error, so the probe always returned null — dead in the fail-closed direction (it fell through to the raw PG_VERSION marker). Fixed to -tAc; the test assertion is updated to match. Surfaced by the real-docker works-after upgrade-postgres arm (cinatra-ai/cinatra#1483).

Not user-visible: an internal detection-adapter fix; no UI surface.

The live version probe (makeProbeVersion, cinatra-cli#129) sent an invalid psql
flag `-tArc` (`-r` is not a psql option), so `SHOW server_version` errored and the
probe always returned null — silently dead (fail-closed: it fell through to the raw
PG_VERSION marker, never a wrong answer). Corrected to `-tAc`. Surfaced by the
real-docker works-after upgrade-postgres arm (cinatra-ai/cinatra#1483).

Assisted-by: Claude Code (claude-opus-4-8)
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d7ee0a92-688c-4904-9e70-08c6b5ddf7e9

📥 Commits

Reviewing files that changed from the base of the PR and between bc4e74d and db86348.

📒 Files selected for processing (2)
  • src/pg-adapters.mjs
  • tests/pg-adapters.test.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lane/pg-adapter-fix

Comment @coderabbitai help to get the list of available commands.

@groganz
groganz merged commit 2b6b780 into main Jul 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant