Skip to content

docs: mocha upgrade height - #1672

Merged
rootulp merged 4 commits into
celestiaorg:mainfrom
rootulp:rp/mocha-upgrade-height
Aug 20, 2024
Merged

docs: mocha upgrade height#1672
rootulp merged 4 commits into
celestiaorg:mainfrom
rootulp:rp/mocha-upgrade-height

Conversation

@rootulp

@rootulp rootulp commented Aug 19, 2024

Copy link
Copy Markdown
Contributor

Description

Add the v2 upgrade height for Mocha. Tagging @tty47 for awareness.

Resources

This value was derived using the blockheight tool from celestia-app/tools with a 12.03 second blocktime based on Mintscan

$ go run main.go https://celestia-mocha-rpc.publicnode.com:443 2024-08-21T14:00:00
chainID: mocha-4
currentHeight: 2528740
currentTime: 2024-08-20 17:53:30.162475958 +0000 UTC
targetHeight: 2534757
targetTime: 2024-08-21 14:00:00 +0000 UTC
diffInSeconds: 72389
diffInBlockHeight: 6017

@rootulp
rootulp requested a review from jcstein August 19, 2024 20:29
@rootulp rootulp self-assigned this Aug 19, 2024
@rootulp
rootulp marked this pull request as draft August 19, 2024 20:29

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77edd2b and 9d6ef5a.

Files selected for processing (3)
  • nodes/consensus-node.md (1 hunks)
  • nodes/hardfork-process.md (1 hunks)
  • nodes/validator-node.md (1 hunks)
Additional comments not posted (3)
nodes/hardfork-process.md (1)

49-49: Upgrade height update for Mocha network.

The upgrade height for the Mocha network has been updated to 2534734, providing clarity and ensuring that users are informed about the specific upgrade timeline.

nodes/validator-node.md (1)

160-160: Specific upgrade height for Mocha network.

The command now includes a specific upgrade height (2534734) for the Mocha network, enhancing clarity for users setting up their validator nodes.

nodes/consensus-node.md (1)

310-310: Specific upgrade height for Mocha network.

The command now specifies the upgrade height (2534734) for the Mocha network, which is essential for users configuring their consensus nodes.

@jcstein jcstein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@rootulp rootulp left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revise using 12.03 second blocktime

Comment thread nodes/consensus-node.md Outdated
Comment thread nodes/hardfork-process.md Outdated
Comment thread nodes/validator-node.md Outdated
@celestiaorg celestiaorg deleted a comment from coderabbitai Bot Aug 20, 2024
@rootulp
rootulp marked this pull request as ready for review August 20, 2024 17:56
@coderabbitai

coderabbitai Bot commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Walkthrough

The changes entail a specific upgrade height being introduced across various documentation files for the Celestia application. The placeholder <height> has been replaced with the fixed value 2534757 in command instructions, signifying a concrete transition within the application lifecycle. Additionally, the upgrade height for the Mocha network has been specified, clarifying the timeline for its upgrade. These updates enhance clarity and consistency regarding versioning and deployment instructions.

Changes

Files Change Summary
nodes/consensus-node.md, The command for starting the Celestia application now uses a fixed upgrade height of 2534757.
nodes/validator-node.md
nodes/hardfork-process.md The Mocha network's upgrade height is updated from "TBD" to "2534757" with a confirmed date of "2024/08/28 @ 14:00 UTC."

Possibly related issues

  • Info on lemongrass hard-fork #1638: The proposed documentation addition aligns with the need for clarity on the new CLI flag (--v2-upgrade-height x) and its implications for various networks, addressing similar concerns about upgrade specifics.

🐇 In the meadow, we hop with cheer,
A fixed height brings the upgrades near.
With clarity and ease, we now embark,
Celestia shines, lighting up the dark!
Hooray for changes, let’s dance and play,
For a brighter tomorrow, hip-hip-hooray! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 77edd2b and 09ab720.

Files selected for processing (3)
  • nodes/consensus-node.md (1 hunks)
  • nodes/hardfork-process.md (1 hunks)
  • nodes/validator-node.md (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • nodes/consensus-node.md
  • nodes/hardfork-process.md
  • nodes/validator-node.md

@rootulp
rootulp merged commit 44d6371 into celestiaorg:main Aug 20, 2024
@rootulp
rootulp deleted the rp/mocha-upgrade-height branch August 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants