Skip to content

feat [WIP]: add p0 tabs draft - #1192

Merged
YazzyYaz merged 36 commits into
mainfrom
jcs/p0
Oct 31, 2023
Merged

feat [WIP]: add p0 tabs draft#1192
YazzyYaz merged 36 commits into
mainfrom
jcs/p0

Conversation

@jcstein

@jcstein jcstein commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Overview

Preview of networks page

Resolves #1199
Resolves #1178
Resolves #1177

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions

github-actions Bot commented Oct 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor
PR Preview Action v1.4.4
🚀 Deployed preview to https://celestiaorg.github.io/docs/pr-preview/pr-1192/
on branch gh-pages at 2023-10-31 13:54 UTC

@jcstein jcstein self-assigned this Oct 26, 2023
@jcstein jcstein added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 26, 2023
@jcstein

jcstein commented Oct 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have reviewed this to check that there are:

  • mainnet tabs where there should be
  • the flow from start of site to end of site (sidebar) works properly, no broken links or "next page" buttons

to be added:

  • mainnet page
  • link to mainnet network with a description on networks page

@jcstein
jcstein requested a review from YazzyYaz October 30, 2023 16:27
jcstein
jcstein commented Oct 31, 2023
View reviewed changes
Comment thread nodes/mainnet.md Outdated
jcstein
jcstein commented Oct 31, 2023
View reviewed changes
Comment thread nodes/mainnet.md Outdated
@jcstein
jcstein marked this pull request as ready for review October 31, 2023 13:26
@YazzyYaz
YazzyYaz merged commit df8ae07 into main Oct 31, 2023
@YazzyYaz
YazzyYaz deleted the jcs/p0 branch October 31, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@YazzyYaz YazzyYaz YazzyYaz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jcstein jcstein

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

2 participants

@jcstein @YazzyYaz