Repository navigation
fix(axonometric): read complete label text including SVG tspans - #331
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Fixes cathrynlavery#297. AI assistance was used for investigation, implementation, and tests. Signed-off-by: Rudy Celekli <rudy@gradiahq.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Read descendant text inside SVG text labels when matching exploded-view and axonometric-plan labels to declared parts. Accumulation is limited to label text ancestors, preserving direct element text without duplicating it on groups or the document.
AI assistance was used for implementation and validation; I reviewed the change and native evidence.
Visual proof
Not applicable: no diagram, example, or template changes. Pinned Chromium renders the styled/nested-tspan variants pixel-identically to the shipped examples. Both public verifiers rejected those labels before the correction; geometry and invalid-label controls remain enforced.
Validation gates
python3 scripts/test-lint-a11y.pypython3 scripts/lint-skin.py --all --baselinepython3 scripts/verify-sequence-oauth.pypython3 scripts/verify-drawio-import.pypython3 scripts/verify-mermaid-import.pygit diff --exit-codegreen afterpython3 scripts/build-icons.py(generated icons unchanged)The initial complete 77-command suite passed 76 commands; render gate 17 reported clipping on unchanged animated assets. The independently reproduced JavaScript playback/capture race is tracked in #312. One actual locked, unchanged-head native rerun of gate 17 passed (209 rendered files, zero findings). Thus all 77 required commands have passed across the original and retry receipts; the initial failure is preserved and no threshold, source, or test exception was used. at signed head
0cc43997f157043e54ed705c6caf6d4b90754636. Native proof uses pinned Playwright 1.62.0 and bundled Chromium 151.0.7922.34 with external network blocked. Hosted CI is pending.Checklist
scripts/lint-skin-baseline.txtRelated issues
Closes #297.