fix: adding new items to an order should not crash - #6
Open
johannes-vogel wants to merge 4 commits into
Open
Conversation
Contributor
|
@johannes-vogel Does this happen because the order is not valid and the order item references a product that does not exist? |
Author
|
It's a new OrderItem that's added to an existing Order. |
Contributor
|
I am trying to identify the use case. The variable before is not initialized because the product referenced by this OrderItem does not exist, right? |
Author
|
For not yet existing Order Items, the quantity of the before image is undefined. This leads to the The correct change is to default to zero instead of the early exit. |
vl-leon
reviewed
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.