Skip to content

android VIEW_MANAGER_NAME is not correct #66

Description

@devvit

Bug

After v2.0 release, android view manager renamed to "RNCViewPager"

public class ReactViewPagerManager extends ViewGroupManager<ReactViewPager> {

  private static final String REACT_CLASS = "RNCViewPager";

  private static final int COMMAND_SET_PAGE = 1;
  private static final int COMMAND_SET_PAGE_WITHOUT_ANIMATION = 2;

but ViewPagerAndroid.js is still "AndroidViewPager"

const VIEW_PAGER_REF = 'viewPager';
const VIEW_MANAGER_NAME = Platform.OS === 'android' ? 'AndroidViewPager' : 'RNCViewPager';

AndroidViewPager is legacy code point to offcial RN:

public class ReactViewPagerManager extends ViewGroupManager<ReactViewPager> {

  public static final String REACT_CLASS = "AndroidViewPager";

  public static final int COMMAND_SET_PAGE = 1;
  public static final int COMMAND_SET_PAGE_WITHOUT_ANIMATION = 2;

Steps To Reproduce

Please add a new COMMAND_FOO like COMMAND_SET_PAGE_WITHOUT_ANIMATION, you cannot pass command through receiveCommand, because the event send to original AndroidViewPager, after change ViewPagerAndroid.js, work correctly.

// const VIEW_MANAGER_NAME = Platform.OS === 'android' ? 'AndroidViewPager' : 'RNCViewPager';
const VIEW_MANAGER_NAME = 'RNCViewPager';

Reproducible sample code

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions