Several tidyings in the C bindings#885
Merged
alexcrichton merged 6 commits intoMar 7, 2024
Merged
Conversation
- Add several comments to the C bindings output - Move the `#include <stdlib.h>` out of the `.h` file and into the `.c` file, since it's for `realloc`/`free` etc. and those are only used in the `.c` file. - Use named structs inside of typedefs, so that the structs have names in the generated debug info.
Mossaka
approved these changes
Mar 7, 2024
alexcrichton
reviewed
Mar 7, 2024
alexcrichton
approved these changes
Mar 7, 2024
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
looks good to me as well, just one minor question
alexcrichton
reviewed
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add several comments to the C bindings output
Move the
#include <stdlib.h>out of the.hfile and into the.cfile, since it's forrealloc/freeetc. and those are only used in the.cfile.Use named structs inside of typedefs, so that the structs have names in the generated debug info.