update to use tagged unions - #41
Merged
Merged
Conversation
Member
pchickey
force-pushed
the
pch/tagged_unions
branch
from
February 7, 2020 20:22
54d98dc to
6d66e84
Compare
Collaborator
Author
|
@kubkon many thanks, ive rebased |
pchickey
force-pushed
the
pch/tagged_unions
branch
from
February 14, 2020 01:14
054bb7f to
9c0d287
Compare
pchickey
marked this pull request as ready for review
February 14, 2020 01:30
| pub use crate::error::Error; | ||
| pub type Result<T, E = Error> = core::result::Result<T, E>; | ||
| pub type Size = usize; | ||
| pub type Size = u32; |
Member
There was a problem hiding this comment.
Was this intentional? IIRC this was a convenience from before because usize is used so ubiquitously in Rust right nwo
alexcrichton
approved these changes
Feb 18, 2020
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Just a question about usize but otherwise lgtm
Collaborator
Author
|
Oops, that was not intentional, I'll revert it. We now have BuiltinType::Size in witx but the snapshot isnt using it yet, so I'll leave the hack to make the target of the type named |
along with a comment describing when its safe to remove
pchickey
force-pushed
the
pch/tagged_unions
branch
from
February 18, 2020 20:57
96382c8 to
1f49584
Compare
Member
|
👍 |
haraldh
pushed a commit
to haraldh/wasi
that referenced
this pull request
Dec 1, 2022
…lliance#112) Move `CLOCK_REALTIME` to be the first `clockid_t` value. This change reflects the definitions used in [existing practice], so this patch updates the `wasi_unstable_preview0` and `wasi_unstable` definitions as well. This is the same change as bytecodealliance#41, but updated for the WASI repository's new phases directory structure. [existing practice]: https://github.com/CraneStation/wasi-libc/blob/master/libc-bottom-half/headers/public/wasi/core.h#L42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until upstream WASI changes are merged into master, and submodule is pointed at master.
Implements WebAssembly/WASI#220