Add string_normalize intrinsic#1023
Merged
Merged
Conversation
saulecabrera
reviewed
Oct 3, 2025
| let target_fuel = target_fuel as f64; | ||
| let fuel_consumed = fuel_consumed as f64; | ||
| let threshold = 2.0; | ||
| let threshold = 3.0; |
Member
There was a problem hiding this comment.
It's not totally clear why this change is needed, but perhaps I'm missing something?
Collaborator
Author
There was a problem hiding this comment.
If I don't make this change, the test_empty test will always fail on one of Linux or MacOS because the difference between the fuel counts on the different operating systems is 2.3% apart with this change.
| } | ||
|
|
||
| if intrinsics.contains(JSIntrinsics::STRING_NORMALIZE) { | ||
| unsafe { intrinsic::StringNormalize::add_intrinsic(ctx.as_raw()) } |
Member
There was a problem hiding this comment.
Could you add an entry here? https://github.com/bytecodealliance/javy/blob/main/docs/docs-using-js-api-support.md -- I guess that page needs a general update, so might be worth doing while you're there, if you feel like it.
saulecabrera
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds the
string_normalizeRQuickJS intrinsic and a method onConfigto make it available or unavailable. It defaults to available similar to how we handle other RQuickJS intrinsics.Also lowers the fuel consumed amount for the empty test because that test was failing for me and increases the threshold to 3% since I can't get the tests to pass on both MacOS and Linux at 2%.
Why am I making this change?
Someone tried to use the
normalizemethod on strings and it didn't exist.Checklist
javy-cli,javy-plugin, andjavy-plugin-processingdo not require updating CHANGELOG files.