feat(folders): drag-and-drop reorder for all folders#645
Open
shukiv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds drag-and-drop reordering of folders in Settings → Folders ("Your Folders"). Each row gets a drag handle; dropping persists the new order via JMAP
Mailbox/set { sortOrder }, and the sidebar reflects it immediately.Reorders all folders (standard roles included), within their sibling group — it reorders, it does not reparent (dropping onto another parent's folder is ignored).
How
lib/utils.ts(buildMailboxTree/sortNodes): promotesortOrderto the primary sort key. Untouched folders keepsortOrder: 0, so the default arrangement (role priority → year → name) is unchanged until the user drags something. Sidebar + settings share this builder, so both respect the order.stores/email-store.ts: newreorderMailboxes(client, orderedIds)— assigns 1-basedsortOrderto a sibling group, optimistic local update, persists each viaupdateMailbox, re-syncs on failure. Handles shared-account (viewingAccountId) views.components/settings/folder-settings.tsx:@dnd-kitDnD context; aSortableContextper sibling group; aSortableFolderRowhandle wrapper. Pointer sensor with a 5px activation distance so the row's existing buttons still work; keyboard sensor for a11y.@dnd-kit/core,@dnd-kit/sortable,@dnd-kit/utilities.settings.folders.reorder/reorder_error(en + he).Testing
tscclean; lint clean (no new warnings)