Start mwebd before btcpayserver (and litecoind before mwebd)#1066
Open
rachyandco wants to merge 1 commit into
Open
Start mwebd before btcpayserver (and litecoind before mwebd)#1066rachyandco wants to merge 1 commit into
rachyandco wants to merge 1 commit into
Conversation
On a cold 'docker compose down && up' (e.g. the nightly btcpay-backup.sh cron), all containers are recreated simultaneously. btcpayserver can reach plugin initialization before mwebd's gRPC port exists, which makes the LitecoinMweb plugin's startup fail with RpcException(Unavailable); BTCPay's crash protection then writes the plugin to the Plugins/disabled kill-list and it stays disabled until an admin re-enables it manually. Declaring the startup order in the fragment closes that race: mwebd is a small Go daemon that binds its port in milliseconds, while btcpayserver takes several seconds to boot to the point of starting plugin hosted services. See ltcmweb/btcpayserver-ltcmweb-plugin#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a cold 'docker compose down && up' (e.g. the nightly btcpay-backup.sh cron), all containers are recreated simultaneously. btcpayserver can reach plugin initialization before mwebd's gRPC port exists, which makes the LitecoinMweb plugin's startup fail with RpcException(Unavailable); BTCPay's crash protection then writes the plugin to the Plugins/disabled kill-list and it stays disabled until an admin re-enables it manually.
Declaring the startup order in the fragment closes that race: mwebd is a small Go daemon that binds its port in milliseconds, while btcpayserver takes several seconds to boot to the point of starting plugin hosted services.
See ltcmweb/btcpayserver-ltcmweb-plugin#3