Fix c warnings - #204
Merged
Merged
Fix c warnings#204
Conversation
`yajl_gen_error` is a `yajl_gen_state` not a `yajl_gen_status`.
This change adds a new value to the enum for an error when the
decremented depth is too low.
Warnings:
```
../../../../ext/yajl/yajl_gen.c:295:5: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status'
[-Wenum-conversion]
DECREMENT_DEPTH;
^~~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:181:48: note: expanded from macro 'DECREMENT_DEPTH'
if (--(g->depth) >= YAJL_MAX_DEPTH) return yajl_gen_error;
~~~~~~ ^~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:321:5: warning: implicit conversion from enumeration type 'yajl_gen_state' to different enumeration type 'yajl_gen_status'
[-Wenum-conversion]
DECREMENT_DEPTH;
^~~~~~~~~~~~~~~
../../../../ext/yajl/yajl_gen.c:181:48: note: expanded from macro 'DECREMENT_DEPTH'
if (--(g->depth) >= YAJL_MAX_DEPTH) return yajl_gen_error;
~~~~~~ ^~~~~~~~~~~~~~
```
Co-authored-by: John Hawthorn <john@hawthorn.email>
`yajl_tok_comment` was not present in the switch case.
Warnings:
```
compiling ../../../../ext/yajl/yajl_lex.c
../../../../ext/yajl/yajl_lex.c:42:13: warning: enumeration value 'yajl_tok_comment' not handled in switch [-Wswitch]
switch (tok) {
^
../../../../ext/yajl/yajl_lex.c:42:13: note: add missing switch cases
switch (tok) {
^
```
Co-authored-by: John Hawthorn <john@hawthorn.email>
brianmario
approved these changes
Jun 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix implicit conversion from enumeration type warning
yajl_gen_erroris ayajl_gen_statenot ayajl_gen_status.This change adds a new value to the enum for an error when the
decremented depth is too low.
Warnings:
Fix missing switch case
yajl_tok_commentwas not present in the switch case.Warnings: