Skip to content

Update execute metadata query to match API response - #890

Merged
swfree merged 3 commits into
mainfrom
md-query-response
May 13, 2021
Merged

swfree merged 3 commits into
mainfrom
md-query-response

Conversation

@swfree

@swfree swfree commented May 11, 2021

Copy link
Copy Markdown
Contributor

Issue Link 🔗

  • Fixes bug where BoxResourceIterable<BoxMetadataQueryItem> results = MetadataTemplate.executeMetadataQuery(...) was returning null results

Implementation Details 🚧

  • Removed the executeMetadataQuery that returns data as BoxMetadataQueryItem. Decided to remove instead of deprecate since the method does not work and always returns null
  • Users should only use the executeMetadataQuery method that returns data as BoxItem.Info

Testing Details 🔍

  • Updated unit tests

sujaygarlanka
sujaygarlanka previously approved these changes May 12, 2021
@sujaygarlanka

Copy link
Copy Markdown
Contributor

@swfree Just some linting errors that need to be fixed for Travis

@swfree
swfree force-pushed the md-query-response branch from 941ab91 to b68eaf1 Compare May 12, 2021 18:47
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2451

  • 1 of 4 (25.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 67.889%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/MetadataTemplate.java 1 4 25.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/EventStream.java 1 87.63%
src/main/java/com/box/sdk/BoxJSONResponse.java 2 93.33%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build 2447: -0.2%
Covered Lines: 6256
Relevant Lines: 9215

💛 - Coveralls

@swfree

swfree commented May 12, 2021

Copy link
Copy Markdown
Contributor Author

Thanks @sujaygarlanka! Fixed the linting errors

@swfree
swfree merged commit b68ebcc into main May 13, 2021
@swfree
swfree deleted the md-query-response branch May 13, 2021 21:50
PJSimon pushed a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants