Skip to content

Add support for the classification field for Files and Folders - #809

Merged
sujaygarlanka merged 8 commits into
masterfrom
classification-field
May 21, 2020
Merged

sujaygarlanka merged 8 commits into
masterfrom
classification-field

Conversation

@sujaygarlanka

Copy link
Copy Markdown
Contributor

Added classification field for BoxFile.Info and BoxFolder.Info.

@coveralls

coveralls commented May 19, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2219

  • 24 of 28 (85.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 65.887%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxFile.java 4 5 80.0%
src/main/java/com/box/sdk/BoxFolder.java 4 5 80.0%
src/main/java/com/box/sdk/BoxClassification.java 16 18 88.89%
Totals Coverage Status
Change from base Build 2215: 0.07%
Covered Lines: 5580
Relevant Lines: 8469

💛 - Coveralls

@sujaygarlanka
sujaygarlanka force-pushed the classification-field branch from 66cc352 to 1d7f26e Compare May 20, 2020 16:37

@PJSimon PJSimon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's match the Doc Comments of BoxFile and BoxFolder to further enforce that these functions return the same data.

Comment thread src/main/java/com/box/sdk/BoxFile.java Outdated
Comment thread src/main/java/com/box/sdk/BoxFolder.java Outdated
sujaygarlanka and others added 2 commits May 21, 2020 11:07
Co-authored-by: Patrick Simon <patrick@box.com>
Co-authored-by: Patrick Simon <patrick@box.com>
@sujaygarlanka
sujaygarlanka merged commit 0260f19 into master May 21, 2020
@sujaygarlanka
sujaygarlanka deleted the classification-field branch May 21, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants