Skip to content

Fix retry logic - #787

Merged
sujaygarlanka merged 21 commits into
masterfrom
amend-retry-logic
Apr 9, 2020
Merged

sujaygarlanka merged 21 commits into
masterfrom
amend-retry-logic

Conversation

@sujaygarlanka

Copy link
Copy Markdown
Contributor

Fix retry logic

  • Retry for 400 invalid_grant error in authentication requests (Clock Skew)
  • Honor Retry-After header if present by waiting for the time specified in the header before retrying
  • Number of request retries after the initial request is now equal to the DEFAULT_MAX_ATTEMPTS config value

@coveralls

coveralls commented Apr 1, 2020

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2174

  • 43 of 60 (71.67%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 65.602%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxDeveloperEditionAPIConnection.java 6 7 85.71%
src/main/java/com/box/sdk/BoxAPIRequest.java 21 24 87.5%
src/main/java/com/box/sdk/BoxGlobalSettings.java 3 6 50.0%
src/main/java/com/box/sdk/BoxAPIConnection.java 11 16 68.75%
src/main/java/com/box/sdk/SharedLinkAPIConnection.java 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/SharedLinkAPIConnection.java 1 0%
src/main/java/com/box/sdk/BoxAPIRequest.java 2 65.38%
Totals Coverage Status
Change from base Build 2172: 0.05%
Covered Lines: 5527
Relevant Lines: 8425

💛 - Coveralls

Comment thread CHANGELOG.md Outdated
Comment thread src/main/java/com/box/sdk/BoxAPIRequest.java Outdated
Comment thread src/main/java/com/box/sdk/BoxAPIConnection.java
Comment thread src/main/java/com/box/sdk/BoxAPIRequest.java
@PJSimon
PJSimon force-pushed the amend-retry-logic branch from 534e6ee to e01a359 Compare April 7, 2020 21:48
Comment thread src/main/java/com/box/sdk/BoxAPIRequest.java
Comment thread src/test/Fixtures/BoxAPIConnection/State.json
Comment thread src/test/java/com/box/sdk/BoxAPIConnectionTest.java Outdated
PJSimon
PJSimon previously approved these changes Apr 8, 2020
PJSimon
PJSimon previously approved these changes Apr 9, 2020
Comment thread src/main/java/com/box/sdk/SharedLinkAPIConnection.java Outdated
Comment thread src/main/java/com/box/sdk/SharedLinkAPIConnection.java Outdated
Comment thread src/main/java/com/box/sdk/BoxGlobalSettings.java Outdated
Comment thread src/main/java/com/box/sdk/BoxAPIConnection.java
Comment thread src/main/java/com/box/sdk/BoxAPIConnection.java
Co-Authored-By: Sujay Garlanka <sujay.garlanka@gmail.com>
Comment thread src/main/java/com/box/sdk/BoxAPIConnection.java
Comment thread src/main/java/com/box/sdk/BoxGlobalSettings.java Outdated
Comment thread CHANGELOG.md Outdated
Comment thread src/main/java/com/box/sdk/BoxAPIConnection.java
Comment thread src/main/java/com/box/sdk/SharedLinkAPIConnection.java Outdated
Comment thread src/main/java/com/box/sdk/SharedLinkAPIConnection.java Outdated
PJSimon
PJSimon previously approved these changes Apr 9, 2020
@sujaygarlanka
sujaygarlanka merged commit 8903796 into master Apr 9, 2020
@sujaygarlanka
sujaygarlanka deleted the amend-retry-logic branch April 9, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants