Skip to content

fix: BoxCollaboration.getItem() returns BoxItem.Info not BoxFolder.Info - #1102

Merged
antusus merged 9 commits into
mainfrom
kb/collaboration_issues
Sep 20, 2022
Merged

fix: BoxCollaboration.getItem() returns BoxItem.Info not BoxFolder.Info#1102
antusus merged 9 commits into
mainfrom
kb/collaboration_issues

Conversation

@antusus

@antusus antusus commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@coveralls

coveralls commented Sep 19, 2022 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #2170

  • 75 of 147 (51.02%) changed or added relevant lines in 4 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.05%) to 70.044%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxCollaboration.java 41 52 78.85%
src/main/java/com/box/sdk/BoxFolder.java 1 17 5.88%
src/main/java/com/box/sdk/BoxFile.java 1 19 5.26%
src/main/java/com/box/sdk/BoxUser.java 32 59 54.24%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/EventStream.java 2 87.63%
src/main/java/com/box/sdk/BoxFolder.java 3 64.74%
src/main/java/com/box/sdk/RealtimeServerConnection.java 3 80.0%
Totals Coverage Status
Change from base Build #2153: 0.05%
Covered Lines: 7356
Relevant Lines: 10502
💛 - Coveralls

@antusus antusus changed the title fix: BoxCollaboration.getItem() should return BoxItem.Info not BoxFolder.Info fix: BoxCollaboration.getItem( returns BoxItem.Info not BoxFolder.Info Sep 19, 2022
@antusus antusus changed the title fix: BoxCollaboration.getItem( returns BoxItem.Info not BoxFolder.Info fix: BoxCollaboration.getItem() returns BoxItem.Info not BoxFolder.Info Sep 19, 2022
arjankowski
arjankowski previously approved these changes Sep 20, 2022
View reviewed changes

@arjankowski arjankowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

arjankowski
arjankowski approved these changes Sep 20, 2022
View reviewed changes

@arjankowski arjankowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antusus
antusus merged commit 135850d into main Sep 20, 2022
@antusus
antusus deleted the kb/collaboration_issues branch September 20, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjankowski arjankowski arjankowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BoxCollaboration.getItem() should return BoxItem.Info not BoxFolder.Info Retry on what errors? (setMaxRetryAttempts)

4 participants

@antusus @coveralls @arjankowski @congminh1254