Skip to content

fix: buffered body write and fixed SDK logging - #1079

Merged
antusus merged 10 commits into
mainfrom
kb/buffered_body_write_and_logging
Aug 5, 2022
Merged

antusus merged 10 commits into
mainfrom
kb/buffered_body_write_and_logging

Conversation

@antusus

@antusus antusus commented Aug 4, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Aug 4, 2022

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build #1844

  • 20 of 37 (54.05%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 69.815%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/box/sdk/BoxAPIRequest.java 17 19 89.47%
src/main/java/com/box/sdk/BoxLogger.java 2 17 11.76%
Files with Coverage Reduction New Missed Lines %
src/main/java/com/box/sdk/MetadataQuery.java 1 92.59%
Totals Coverage Status
Change from base Build #1807: 0.1%
Covered Lines: 7237
Relevant Lines: 10366

💛 - Coveralls

lukaszsocha2
lukaszsocha2 previously approved these changes Aug 4, 2022

@lukaszsocha2 lukaszsocha2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. Please remember that removing public method enableLogger() is small breaking change and we need to communicate it proper way

@antusus
antusus merged commit bc35ef3 into main Aug 5, 2022
@antusus
antusus deleted the kb/buffered_body_write_and_logging branch August 5, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants