transport: advertise MaxIncomingStreams via zquic ServerConfig (finish #65) - #76
Merged
Conversation
…#65) Bumps zquic to v1.7.67 (which adds `io.ServerConfig.max_incoming_streams` / `max_incoming_uni_streams`) and wires the shim's `QuicConfig` incoming-stream limits into both `io.ServerConfig` build sites. The `EthEcQuicConfig` 16384-stream limit is now actually advertised as `initial_max_streams_ {bidi,uni}` in the server's transport parameters, so a peer may open our configured number of per-chunk streams instead of the preset default (1000) — completing the plumbing started in #65 (values previously reached the shim but had nowhere to go).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the plumbing started in #65. Previously the
EthEcQuicConfig.max_incoming_*limits reached the shim'sQuicConfigbut had nowhere to go — zquic'sio.ServerConfighad no numeric incoming-stream field.zquic v1.7.67 (ch4r10t33r/zquic#238) added
ServerConfig.max_incoming_streams/max_incoming_uni_streams. This PR:zquicdependency v1.7.66 → v1.7.67, andQuicConfiglimits into bothio.ServerConfigbuild sites (endpointInitandendpointInitFromFd).The
EthEcQuicConfig16384-stream default is now actually advertised asinitial_max_streams_{bidi,uni}in the server's transport parameters, so a peer may open our configured number of per-chunk QUIC streams instead of the preset default (1000).Verification
zig fmt --check,zig build test,zig build test-quicpass on stock Zig 0.16.0. (The end-to-end "client parses the advertised limit" assertion lives in the zquic loopback test added in zigstack/zquic#238.) README updated to reflect the full path.Note: the zquic v1.7.67 release also carries the fix for the
resumption/zerorttinterop regression (ch4r10t33r/zquic#239).