Skip to content

style: add center dot to unread badges (Discord-style) #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wpfleger96 wants to merge 1 commit into from
+18 −5
Closed

style: add center dot to unread badges (Discord-style) #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions desktop/src/features/sidebar/ui/SidebarSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,11 @@ export function ChannelMenuButton({
{hasUnread && !isActive && channel.channelType !== "dm" ? (
<span
aria-hidden="true"
className="ml-auto h-2.5 w-2.5 shrink-0 rounded-full bg-primary"
className="ml-auto flex h-2.5 w-2.5 shrink-0 items-center justify-center rounded-full border-[1.5px] border-primary bg-transparent"
data-testid={`channel-unread-${channel.name}`}
/>
>
<span className="h-1 w-1 rounded-full bg-primary" />
</span>
) : null}
</SidebarMenuButton>
);
Expand Down Expand Up @@ -304,9 +306,11 @@ export function SidebarSection({
!(isActiveChannel && selectedChannelId === channel.id) ? (
<span
aria-hidden="true"
className="absolute right-[9px] top-1/2 h-2.5 w-2.5 -translate-y-1/2 rounded-full bg-primary"
className="absolute right-[9px] top-1/2 flex h-2.5 w-2.5 -translate-y-1/2 items-center justify-center rounded-full border-[1.5px] border-primary bg-transparent"
data-testid={`channel-unread-${channel.name}`}
/>
>
<span className="h-1 w-1 rounded-full bg-primary" />
</span>
) : null}
{channel.channelType === "dm" && onHideDm ? (
<SidebarMenuAction
Expand Down
11 changes: 10 additions & 1 deletion mobile/lib/features/channels/channels_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,10 +931,19 @@ class _ChannelTile extends ConsumerWidget {
key: Key('channel-unread-${channel.id}'),
width: 8,
height: 8,
alignment: Alignment.center,
decoration: BoxDecoration(
color: context.colors.primary,
border: Border.all(color: context.colors.primary, width: 1.5),
shape: BoxShape.circle,
),
child: Container(
width: 3,
height: 3,
decoration: BoxDecoration(
color: context.colors.primary,
shape: BoxShape.circle,
),
),
),
],
if (!channel.isMember && !channel.isDm)
Expand Down