chore(desktop): clear desktop-tauri clippy backlog#1612
Merged
Conversation
Fix all 26 pre-existing clippy -D warnings errors in the desktop Tauri crate so `just desktop-tauri-clippy` (and the local `just check` aggregate) passes again. CI does not run this target, so the backlog had accumulated on main. - readiness.rs: gate test-only AgentReadiness helpers with #[cfg(test)], drop the unused Requirement::label, is_none_or/is_some_and, collapse provider match guards; keep config_file_path behind #[allow(dead_code)] since chunk A replaces that resolution path wholesale - runtime.rs: drop unused sweep re-exports, use slice::contains (mechanical-only per coordination with the unified-agent-record work) - agent_models.rs: remove the no-op preserve_first_separator branch and its parameter (both arms were identical) - archive/: needless test borrows; #[allow(too_many_arguments)] for the three column-mirroring store/pipeline fns where a params struct would only rename the problem - config_bridge/: struct-literal init in claude.rs test helper, named ResolvedOverride type alias, #[allow(too_many_arguments)] on build_model_field No behavior change; 1023 desktop tests pass, fmt and file-size gates clean. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears all 26 pre-existing clippy
-D warningserrors in the desktop Tauri crate sojust desktop-tauri-clippy— and with it the localjust checkaggregate — passes again. CI doesn't run this target, so the backlog had accumulated on main (flagged during #1601/#1602 review as a separate cleanup chunk).No behavior change intended anywhere in this diff.
What was fixed, by category
Mechanical simplifications (bulk):
readiness.rs:map_or→is_none_or/is_some_and; collapsed if-into-match-guard on the provider credential matches (semantics verified: a present key fails the guard and falls through to the empty_arm, identical to the old inner-if-does-nothing)runtime.rs: removed unusedpub use sweep::{...}re-export (all uses are insidesweep.rs),iter().any()→slice::containsarchive/mod_tests.rs: 4× needless borrow on"A".repeat(200)personas/writeback.rs: redundant closureconfig_bridge/claude.rstest helper: struct-literal init instead of field-reassign-with-defaultRoot-cause fixes rather than lint silencing:
agent_models.rs: theidentical if blockslint exposed thatpreserve_first_separatorwas inert (both arms returnedpartat index 0) — removed the parameter entirelyconfig_bridge/reader.rs: namedResolvedOverridetype alias for the very-complex-type lintDeliberate
#[allow]s with rationale comments:too_many_arguments×4 (archive/store.rs×2,archive/pipeline.rs,config_bridge/reader.rs): these fns mirror table columns or are single-caller internals — a params struct would rename the problem, not fix itreadiness.rsconfig_file_pathdead-code: kept behind#[allow(dead_code)]+ note because the in-flight unified-agent-record work (chunk A) replaces that resolution path wholesale; deleting it here would create churn against that branchreadiness.rsis_ready/requirements: used only by tests → gated#[cfg(test)];Requirement::label()had zero callers → deletedCoordination note
runtime.rs/readiness.rschanges were kept intentionally mechanical to avoid conflicting with the in-flightfeat/unified-agent-recordbranch, per agreement with its author.Testing
just desktop-tauri-clippygreen (was 26 errors)just desktop-tauri-fmt-checkgreen