fix(desktop): fetch profiles for reaction actors and thread-reply authors#1550
Merged
Conversation
Co-authored-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co>
wpfleger96
approved these changes
Jul 7, 2026
wesbillman
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reaction pill popovers sometimes show a truncated pubkey instead of the reactor's display name (
80c5f18b… reacted with :party_blob:) — reported by Wes in #buzz-bugs.Root cause: reaction (kind-7) actors were never included in the profile fetch set.
ChannelScreenbuildsmessageProfilePubkeysfromcollectMessageAuthorPubkeys()(+ mentions/DM participants/agents/typing), and that collector filters onisTimelineContentEvent()— kind-7 excluded.formatTimelineMessagesthen renders each reactor viaprofiles?.[actorPubkey]with a${pubkey.slice(0,8)}…fallback.The exclusion is old, but the pre-#1500 client-assembled cache accumulated deep channel history, so nearly every reactor had also authored some message in the soup and got a name by side effect. Post-#1500 the timeline is one server-assembled window page; a reactor with no authored row inside the current page falls through to the fallback. (#1514's delta profile fetch is unrelated — it changes how the set is fetched, not what's in it.)
The thread panel had the same gap one level deeper:
useIndependentThreadPanelfetched thread replies via its ownuseThreadRepliescache, so deep-thread reply authors and their reactors never reached the profile batch either.Fix
collectReactionActorPubkeys(events)(kind-7 only, actor-tag aware, skips deleted reactions, lowercase/dedup) — deliberately separate fromcollectMessageAuthorPubkeys, whose timeline-content semantics other callers rely on.ChannelScreenmerges reaction actors into the users-batch profile set, over[...resolvedMessages, ...threadReplyEvents].useThreadReplieshoisted intoChannelScreen;threadReplyEventsfeeds both the profile pubkey collection anduseIndependentThreadPanel— thread reply authors/reactors now resolve from the same profile batch.Note: a few explanatory comments in
ChannelScreen.tsxwere trimmed to keep the file under the 1000-line CI gate (at 997 before this change); behavior they described is unchanged.Validation
sprout-oss.stage.blox.sqprod.covia in-cluster port-forward), targeting Wes's exact message/reaction."80c5f18b… reacted with :party_blob:"; 8 kind-0 batches / 72 pubkeys requested — reactor's pubkey in none of them."tho reacted with :party_blob:"; reactor's kind-0 requested and resolved.collectReactionActorPubkeyscoverage informatTimelineMessages.test.mjs; full desktop unit suite 1630 pass / 0 fail.reaction-names.spec.ts(smoke project) — reactor with no authored message in the window resolves by name.pnpm check+pnpm buildgreen; ChannelScreen still under the size gate at 997 lines.Diagnosis thread: #buzz-bugs
40260a3e. Implementation by Max; root-cause + staging verification by Eva.