Skip to content

Group consecutive desktop messages#1429

Merged
wesbillman merged 1 commit into
mainfrom
kennylopez-message-grouping
Jul 1, 2026
Merged

Group consecutive desktop messages#1429
wesbillman merged 1 commit into
mainfrom
kennylopez-message-grouping

Conversation

@klopez4212

@klopez4212 klopez4212 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Group consecutive same-author messages across channel timelines, threads, DMs, and inbox detail views.
  • Show continuation timestamps in the avatar gutter on hover without repeating AM/PM.
  • Make inbox avatar/profile affordances match the rest of the app.

Checks

  • pnpm --dir desktop exec biome check ...
  • node --import ./test-loader.mjs --experimental-strip-types --test ...
  • pnpm typecheck
  • git diff --check
  • pre-push desktop/mobile/Tauri/Rust tests

Snapshots

Channel grouping

Continuation rows omit the repeated avatar/name and reveal the compact timestamp on hover.

Channel grouping

Inbox profile panel

Inbox avatars use the same profile-opening path as the rest of the app.

Inbox profile panel

@klopez4212 klopez4212 marked this pull request as ready for review July 1, 2026 15:51
@klopez4212 klopez4212 requested a review from wesbillman July 1, 2026 15:51
klopez4212 added a commit that referenced this pull request Jul 1, 2026
@klopez4212 klopez4212 force-pushed the kennylopez-message-grouping branch from 9fb28b8 to c9507d6 Compare July 1, 2026 15:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fb28b889b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageRow.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-message-grouping branch from c9507d6 to f65a0b9 Compare July 1, 2026 16:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f65a0b9be1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/messages/ui/MessageRow.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-message-grouping branch 2 times, most recently from 2541856 to e6aecae Compare July 1, 2026 17:19

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6aecae521

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/home/ui/InboxListPane.tsx Outdated
@klopez4212 klopez4212 force-pushed the kennylopez-message-grouping branch from e6aecae to acdabfa Compare July 1, 2026 18:02
@wesbillman wesbillman enabled auto-merge (squash) July 1, 2026 18:13
@wesbillman wesbillman merged commit 3d08c3b into main Jul 1, 2026
25 checks passed
@wesbillman wesbillman deleted the kennylopez-message-grouping branch July 1, 2026 18:13
tellaho added a commit that referenced this pull request Jul 2, 2026
…l drift

Desktop Smoke E2E (3) fails deterministically on CI Linux at 28.5px anchor
drift vs the 28px budget in "preserves user scroll while older channel
history loads" — all retries produce the identical 28.5 reading, and a
layout probe shows branch and main render identical timeline metrics, so
this is subpixel settle variance, not a layout regression from this
branch. Bump the budget to 32px, still far below the row-sized jump
(~46px) that the real anchor-shove bug produces. The budget has tracked
density changes before: 2 -> 16 (#1426) -> 28 (#1429).

Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants