feat(mobile): harden unread badges and float tabs#1298
Merged
Conversation
Port mobile unread badge computation to the observed-event model used by desktop so read markers can clear channel, thread, and individual message scopes correctly. Replace the Material bottom navigation with a compact floating tab bar and keep page FABs clear of the floating surface. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Add a PR markdown checker for Buzz relay media URLs and run it from the screenshot posting helper when a body template is supplied. Document the mobile simulator screenshot path so PR images are hosted before being linked. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NavigationBarwith a compact floating/glass tab bar and keep page FABs clear of the floating surface.Screenshots
Validation
flutter analyze lib/features/home/home_page.dart lib/features/channels/channel_detail_page.dart lib/features/channels/channels_page.dart lib/features/channels/channels_provider.dart lib/features/channels/read_state/read_state_format.dart lib/features/channels/thread_detail_page.dart lib/features/channels/unread_badge/should_notify_for_event.dart lib/features/channels/unread_badge/unread_badge_provider.dart lib/features/channels/unread_badge/observed_unread_event.dart test/features/channels/unread_badge/unread_badge_provider_test.dartflutter test test/features/channels/unread_badge/unread_badge_provider_test.dartflutter test test/features/channels/channels_provider_test.dartflutter test test/features/channels/channel_detail_page_test.dartgit diff --checkNotes
flutter runstill prints the existingTarget native_assets required define SdkRoot but it was not providedwarning, but the app launches and renders in the simulator.