Skip to content

test(e2e): raise scroll-history pagination test timeout to 90s#1234

Merged
tellaho merged 1 commit into
mainfrom
tho/scroll-history-timeout-bump
Jun 24, 2026
Merged

test(e2e): raise scroll-history pagination test timeout to 90s#1234
tellaho merged 1 commit into
mainfrom
tho/scroll-history-timeout-bump

Conversation

@tellaho

@tellaho tellaho commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Overview

Category: fix (test infrastructure)
User Impact: No user-facing change — restores CI reliability for a budget-bound E2E test.

Problem: The E2E test scroll-history.spec.tschannel intro stays hidden while paginating past the timeline cap is a budget-bound flake. It seeds ~2160 events and drives ~200 mouse.wheel iterations with 80ms settle waits — a genuinely heavy browser-scroll loop — against a hard 60s cap with near-zero headroom. It reliably passes on fast local hardware but tips over 60s on the slower GH-hosted runner.

Solution: Raise the per-test timeout from 60s → 90s to restore the ~3x margin the GH runner needs. One-line change plus an explanatory comment; nothing else touched.

Why this is a budget problem, not a regression

This test currently blocks #1229 (owner-pane activity gate), but the failure is not #1229's fault — the diagnosis:

So the test was always one slow runner away from red. 90s gives it the headroom CI needs.

Changes

File changes

desktop/tests/e2e/scroll-history.spec.ts
Raised testInfo.setTimeout(60_000)90_000 for the "channel intro stays hidden while paginating past the timeline cap" test, with a comment explaining the runner-slowdown / near-zero-headroom rationale.

Reproduction Steps

  1. Check out main and run the affected test: pnpm --filter desktop test:e2e scroll-history.spec.ts -g "paginating past the timeline cap".
  2. On fast local hardware it passes in ~24s. On a slower GH-hosted runner it can exceed the old 60s cap.
  3. With this change the cap is 90s, restoring margin for the slow runner.

Blocks-fix for #1229 — once this merges, #1229 rebases onto updated main and CI goes green.

Co-authored-by: Taylor Ho taylorkmho@gmail.com
Signed-off-by: Taylor Ho taylorkmho@gmail.com

@tellaho tellaho force-pushed the tho/scroll-history-timeout-bump branch from f276681 to 9389d0c Compare June 24, 2026 05:45
The 'channel intro stays hidden while paginating past the timeline cap'
test seeds ~2160 events and drives ~200 mouse.wheel iterations with 80ms
settle waits. It runs ~24s on fast local hardware but the GH-hosted runner
is ~2.5-3x slower on this loop, leaving near-zero headroom under the 60s
cap. A passing CI run measured 45.5s of the 60s budget; a slower runner
tips it over 60s, which has been blocking PR #1229 (the failing test is
byte-identical to main and unrelated to that PR's changes). Bump to 90s to
restore the ~3x margin CI needs.

Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
@tellaho tellaho force-pushed the tho/scroll-history-timeout-bump branch from 9389d0c to 46883d6 Compare June 24, 2026 05:47
@tellaho tellaho merged commit 09dbeb8 into main Jun 24, 2026
25 checks passed
@tellaho tellaho deleted the tho/scroll-history-timeout-bump branch June 24, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants