test(e2e): raise scroll-history pagination test timeout to 90s#1234
Merged
Conversation
f276681 to
9389d0c
Compare
The 'channel intro stays hidden while paginating past the timeline cap' test seeds ~2160 events and drives ~200 mouse.wheel iterations with 80ms settle waits. It runs ~24s on fast local hardware but the GH-hosted runner is ~2.5-3x slower on this loop, leaving near-zero headroom under the 60s cap. A passing CI run measured 45.5s of the 60s budget; a slower runner tips it over 60s, which has been blocking PR #1229 (the failing test is byte-identical to main and unrelated to that PR's changes). Bump to 90s to restore the ~3x margin CI needs. Co-authored-by: Taylor Ho <taylorkmho@gmail.com> Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
9389d0c to
46883d6
Compare
wesbillman
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Category:
fix(test infrastructure)User Impact: No user-facing change — restores CI reliability for a budget-bound E2E test.
Problem: The E2E test
scroll-history.spec.ts› channel intro stays hidden while paginating past the timeline cap is a budget-bound flake. It seeds ~2160 events and drives ~200mouse.wheeliterations with 80ms settle waits — a genuinely heavy browser-scroll loop — against a hard 60s cap with near-zero headroom. It reliably passes on fast local hardware but tips over 60s on the slower GH-hosted runner.Solution: Raise the per-test timeout from 60s → 90s to restore the ~3x margin the GH runner needs. One-line change plus an explanatory comment; nothing else touched.
Why this is a budget problem, not a regression
This test currently blocks #1229 (owner-pane activity gate), but the failure is not #1229's fault — the diagnosis:
git diff origin/mainon the file is empty); last touched by desktop: fix scrollback paging and visible history depth #1153 / fix(desktop): single-owner anchored scroll for dynamic loading #1115. This isn't fix(observability): gate agent observability on declared ownership, not key custody #1229's code.So the test was always one slow runner away from red. 90s gives it the headroom CI needs.
Changes
File changes
desktop/tests/e2e/scroll-history.spec.ts
Raised
testInfo.setTimeout(60_000)→90_000for the "channel intro stays hidden while paginating past the timeline cap" test, with a comment explaining the runner-slowdown / near-zero-headroom rationale.Reproduction Steps
mainand run the affected test:pnpm --filter desktop test:e2e scroll-history.spec.ts -g "paginating past the timeline cap".Blocks-fix for #1229 — once this merges, #1229 rebases onto updated
mainand CI goes green.Co-authored-by: Taylor Ho taylorkmho@gmail.com
Signed-off-by: Taylor Ho taylorkmho@gmail.com