fix(desktop): restore channel unread badges#1218
Conversation
|
@codex please review |
![chatgpt-codex-connector[bot]](https://avatars.github.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4791a23249
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) | ||
| ) { | ||
| } else { | ||
| options.onChannelMessage?.(channelId, event); |
There was a problem hiding this comment.
When an interested non-DM thread reply arrives, this new unconditional onChannelMessage call runs before the thread-specific callback. In AppShell, onChannelMessage is wired to handleChannelNotification, which calls requestDockBounce() whenever desktop notifications are enabled, while handleThreadReplyDesktopNotification is the path that respects slotAlertsEnabled.thread_reply. This means users who disable Thread replies still get dock attention for those replies; keep the unread bookkeeping separate from the generic channel alert callback or gate this call for thread replies.
Useful? React with 👍 / 👎.
wesbillman
force-pushed
the
pinky/unread-badges-regression
branch
2 times, most recently
from
7b1a060 to
627e784
Compare
Treat interested non-DM thread replies as channel unread events again while keeping normal channel messages dot-only. Split sidebar badge counts from desktop app badge state so mentions/DMs/thread replies remain numeric, ordinary channel traffic only bolds the row, and any channel unread still lights the desktop app badge dot. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
wesbillman
force-pushed
the
pinky/unread-badges-regression
branch
from
627e784 to
ed50e2b
Compare
2 participants
Summary
Validation
bin/pnpm --dir desktop exec tsc --noEmitbin/pnpm --dir desktop check:file-sizesbin/pnpm --dir desktop exec biome check src/app/AppShell.tsx src/app/AppShell.helpers.ts src/app/AppShell.helpers.test.mjsbin/pnpm --dir desktop exec biome check src/app/AppShell.tsx tests/e2e/badge.spec.tsbin/pnpm --dir desktop exec biome check tests/e2e/channels.spec.ts tests/e2e/thread-unread-screenshots.spec.tsbin/pnpm --dir desktop test -- src/app/AppShell.helpers.test.mjs(desktop suite: 1100 pass)bin/pnpm --dir desktop test -- src/features/channels/unreadReadMarker.test.mjs(desktop suite: 1097 pass)bin/pnpm --dir desktop checkbin/pnpm --dir desktop buildbin/pnpm --dir desktop exec playwright test tests/e2e/badge.spec.ts --project=smoke(8 pass)bin/pnpm --dir desktop exec playwright test tests/e2e/channels.spec.ts --project=smoke --grep "sidebar shows unread indicator for (newly active channels|new forum posts)"(2 pass)bin/pnpm --dir desktop exec playwright test tests/e2e/thread-unread-screenshots.spec.ts --project=smoke --grep "(11-thread-reply-lights-sidebar-badge-after-channel-view|12-thread-reply-lights-all-replies-sidebar-badge)"(2 pass)desktop-test,mobile-test,rust-tests,desktop-tauri-testall passed