Skip to content

fix(desktop): defer agent page secondary requests#1217

Merged
wesbillman merged 1 commit into
mainfrom
pinky/async-agent-page
Jun 23, 2026
Merged

fix(desktop): defer agent page secondary requests#1217
wesbillman merged 1 commit into
mainfrom
pinky/async-agent-page

Conversation

@wesbillman

Copy link
Copy Markdown
Collaborator

Summary

  • defer the expensive get_channels query on the Agents page until after the initial view commits
  • keep channel-aware stop/delete flows safe by fetching channels on demand if the background query has not completed
  • avoid mounting closed Agents-page dialogs so runtime/provider discovery and prereq checks do not run until the dialog opens
  • avoid mounting each row's edit dialog until the user opens it

Validation

  • bin/pnpm --dir desktop typecheck
  • bin/pnpm --dir desktop check
  • bin/pnpm --dir desktop build (existing Vite chunk-size / ineffective-dynamic-import warnings only)
  • git diff --check
  • pre-commit hook via git commit (desktop/web/mobile/rust format/check hooks)
  • pre-push hook via CMAKE_POLICY_VERSION_MINIMUM=3.5 git push -u origin pinky/async-agent-page (desktop-test, rust-tests, mobile-test, desktop-tauri-test)

Note: the first pre-push attempt failed before running app tests because the local CMake version rejected the vendored Opus project's old cmake_minimum_required; setting CMAKE_POLICY_VERSION_MINIMUM=3.5 allowed the existing dependency build to proceed, and the hook then passed.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
@wesbillman wesbillman merged commit bee2d64 into main Jun 23, 2026
25 checks passed
@wesbillman wesbillman deleted the pinky/async-agent-page branch June 23, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants