fix(desktop): keep settings shortcut from opening search#1204
Merged
Conversation
Co-authored-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Opening settings navigates away from the normal app shell. Without stopping propagation, other global shortcut listeners can still observe the same keydown during the route transition, which leaves the app with the search dialog open after returning from settings.
Validation
bin/pnpm --dir desktop exec biome check src/app/useSettingsShortcuts.ts tests/e2e/navigation.spec.tsbin/pnpm --dir desktop typecheckbin/pnpm --dir desktop buildbin/pnpm --dir desktop exec playwright test tests/e2e/navigation.spec.ts --project=smoke --grep "settings shortcut returns without opening search dialog"desktop-fix,desktop-tauri-fmt,rust-fmt,mobile-fix,web-fix)desktop-test,desktop-tauri-test,mobile-test,rust-tests)