Skip to content

desktop: drop redundant post-subscribe history refetch #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlongwell-block merged 1 commit into from
Jun 19, 2026
Merged

desktop: drop redundant post-subscribe history refetch #1130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions desktop/src/features/messages/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,16 +277,15 @@ export function useChannelSubscription(channel: Channel | null) {
}

cleanup = dispose;

void syncLatestHistory().catch((error) => {
if (!isDisposed) {
console.error(
"Failed to refresh channel history after subscribing",
channelId,
error,
);
}
});
// No post-subscribe history refetch: useChannelMessagesQuery already
// loaded the latest CHANNEL_HISTORY_LIMIT (200) events, and the live
// subscription itself backfills up to 50 most-recent events via its
// initial REQ (buildChannelFilter(id, 50)). Both write into the same
// channelMessagesKey cache, so any window between the two REQs is
// covered by the live sub's overlap unless >50 messages land in
// <1s — vanishingly rare in practice. The reconnect listener above
// still bridges gaps from connection drops, where the gap *is*
// unbounded.
})
.catch((error) => {
console.error("Failed to subscribe to channel", channelId, error);
Expand Down