[29.x] validation: correct lifetime of precomputed tx data - #35212
Merged
Conversation
This makes sure `txsdata` always outlives the Script check queue (since local objects are destructed in reverse order of construction). This is the root cause for a security vulnerability reported by Cory Fields in 2024 that could be exploited by crafting an invalid block to cause nodes to read freed memory. The vulnerability was covertly fixed in commit `492e1f09943fcb6145c21d470299305a19e17d8b`. See security advisory for CVE-2024-52911 for more details. Github-Pull: bitcoin#35209 Rebased-From: 1ed799f
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35212. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
fanquake
changed the title
Member
|
ACK 9ad085b |
theuni
approved these changes
May 6, 2026
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
…ed tx data 3e95486 validation: correct lifetime of precomputed tx data (Antoine Poinsot) Pull request description: This backports bitcoin#35209 to the version 29 branch. ACKs for top commit: achow101: ACK 3e95486 theuni: ACK 3e95486 Tree-SHA512: e9dd4d43ee348015d3b7b485bef4617c69ad8e0c70589f84a16eb2b1d97bdefd21ce5d72ad6a2d8d25bc90d98f65d53374ca921210cab3b0db773072126459f6
Merged
sedited
added a commit
that referenced
this pull request
Jun 23, 2026
88cd3a7 doc: update manual pages for v29.4rc1 (fanquake) 116565b build: bump version to v29.4rc1 (fanquake) d82afa9 doc: update release notes for v29.4rc1 (fanquake) ea8fafd fuzz: Remove unused g_setup pointers (MarcoFalke) 1907b3f coins: compact chainstate in background (Lőrinc) 9dd8e32 validation: randomly compact chainstate (Lőrinc) e0ab4cf coins: test chainstate flush baseline (Lőrinc) 53a5c7f lint: disable leveldb subtree check (fanquake) Pull request description: Backports: * #35465 Final changes for v`29.4rc1`. Backports since 29.3: * #34680 * #34855 * #35212 * #35234 ACKs for top commit: sedited: ACK 88cd3a7 Tree-SHA512: 57d647f0baf124128d84072c3865cca72ca4a266e95f88b8e1313230aa70a25d76d372e042b095312325b57983805943179d46bfa898522303e90adb69c74347
tomt1664
added a commit
to tomt1664/elements
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #35209 to the version 29 branch.