[29.x] Backports - #33611
Merged
Merged
Conversation
$FILE_ENV has a full relative path already, prepending with ci/test/ results in a non-existent path which means that DEPENDS_HASH was not actually committing to the test's environment file. Github-Pull: bitcoin#33581 Rebased-From: ceeb53a
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33611. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
When using `docker buildx build` in conjunction with the `gha` backend cache type, it's important to specify the URL and TOKEN needed to authenticate. On Cirrus runners this is working with only `ACTIONS_CACHE_URL` and `ACTIONS_RUNTIME_TOKEN`, but this is not enough for the GitHub backend. Fix this by exporting all `ACTIONS_*` variables. This fixes cache restore/save on forks or where GH-hosted runners are being used. Github-Pull: bitcoin#33508 Rebased-From: bc70695
fanquake
force-pushed
the
29_3_backports
branch
from
October 14, 2025 09:03
6638c6e to
5345b25
Compare
This was referenced Oct 14, 2025
fanquake
force-pushed
the
29_3_backports
branch
from
October 14, 2025 16:31
5345b25 to
4917d0c
Compare
fanquake
marked this pull request as ready for review
November 11, 2025 14:46
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
c36ec7d doc: update release notes for 29.x (fanquake) 8236070 test: change log rate limit version gate from 299900 to 290100 (Eugene Siegel) 8a060b4 ci: expose all ACTIONS_* vars (willcl-ark) 770264f ci: Properly include $FILE_ENV in DEPENDS_HASH (Ava Chow) Pull request description: Backports: * bitcoin#33508 * bitcoin#33581 * bitcoin#33612 ACKs for top commit: willcl-ark: ACK c36ec7d Tree-SHA512: fc0660a8087a2791ff969d1a006ec9690c2a2eb3db923fa21c9081e506868a6473638be3d19120d4a812dcf82ae47c8b16359bb695582b78b0dc7ee14e377adf
ivanlele
added a commit
to ivanlele/elements
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports: