Quote dollar signs when not by themself#31
Merged
Conversation
BolunThompson
force-pushed
the
master
branch
from
b26387f to
d372239
Compare
Collaborator
|
This looks good, but for some reason CI hasn't run (and I'd like to confirm that all tests pass before merging!). 🤔 |
BolunThompson
force-pushed
the
master
branch
3 times, most recently
from
44db310 to
09fb8cf
Compare
Member
|
@mgree could it be that the branch is not a libdash branch? I am struggling to understand why tests didn't run here... |
Collaborator
|
Yeah, no idea. I have "Require approval for first-time contributors" turned on but... 🤔 🤔 🤔 If you can run tests locally and they pass, I'm okay to merge and see if things fail on main. |
Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
Contributor
Author
|
After making the equivalent change in the ocaml pretty printer, all the tests pass on my machine: https://gist.github.com/BolunThompson/b073fe50dbd3b4995f26bd564b5cc546 |
mgree
pushed a commit
that referenced
this pull request
Apr 29, 2026
Fix up escaping of `$`; revise tests to support. --------- Signed-off-by: Bolun Thompson <bolunthompson@ucla.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to binpash/shasta#3. There’s the broader question of whether we can remove the (libdash, presumably) pretty printer and instead use the shasta pretty printer, but this copies the change from the shasta printer to libdash.