Skip to content

feat(lmi): remove lmi, let ui and api take over ports, and serve rancher node drivers through httpd#16

Merged
github-actions[bot] merged 2 commits into
developfrom
jim.lin/feat/remove-lmi
May 14, 2025
Merged

feat(lmi): remove lmi, let ui and api take over ports, and serve rancher node drivers through httpd#16
github-actions[bot] merged 2 commits into
developfrom
jim.lin/feat/remove-lmi

Conversation

@Eandalf-Bigstack
Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • feature

What this PR does / why we need it

  • Remove LMI
  • Let UI and API take over ports
  • Serve Rancher node drivers through httpd

Which issue(s) this PR fixes

Special notes for your reviewer

Additional documentation

Copy link
Copy Markdown
Collaborator

@leechienpang leechienpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unplugging all LMI-related functionalities in cubecos is fine. However, hex is a designed to be standalone and reusable for future appliance-like products. That's also why it is a separate repo. I'd say we keep hex as is while all these changes take place in cubecos.

@Eandalf-Bigstack
Copy link
Copy Markdown
Collaborator Author

Keeping LMI in cpp related files would be fine since, for CubeCOS, these code in Hex would not take effect. However, scripts/makehotfix, scripts/makehotfixdraft, and scripts/mountrootfs these three files would affect the file system, particularly, folder /var/www/html and /var/www/lmi. Are we going to keep /var/www/lmi in those scripts and maintain the permission of /var/www/html in CubeCOS?

@leechienpang
Copy link
Copy Markdown
Collaborator

I don't see any harm keeping the behaviors of makehotfixdraft, make hotfix and mountrootfs. The only leftover that users can notice is probably seeing some "LMI" strings when they use hex specific CLI but no big deal.

@Eandalf-Bigstack
Copy link
Copy Markdown
Collaborator Author

Got it, would revert the changes.

@Eandalf-Bigstack Eandalf-Bigstack force-pushed the jim.lin/feat/remove-lmi branch 2 times, most recently from 2841c3f to 144369d Compare May 13, 2025 14:05
…her node drivers through httpd

Signed-off-by: Jim Lin <jim.lin@bigstack.co>
This reverts commit c13c669.

Signed-off-by: Jim Lin <jim.lin@bigstack.co>
@Eandalf-Bigstack
Copy link
Copy Markdown
Collaborator Author

@leechienpang We would need at least one approval to merge this PR.

@Eandalf-Bigstack Eandalf-Bigstack added the done Merge the pull request label May 14, 2025
@github-actions github-actions Bot merged commit 2096cf3 into develop May 14, 2025
1 check passed
@Eandalf-Bigstack Eandalf-Bigstack deleted the jim.lin/feat/remove-lmi branch May 14, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

done Merge the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants