feat(lmi): remove lmi, let ui and api take over ports, and serve rancher node drivers through httpd#16
Conversation
leechienpang
left a comment
There was a problem hiding this comment.
Unplugging all LMI-related functionalities in cubecos is fine. However, hex is a designed to be standalone and reusable for future appliance-like products. That's also why it is a separate repo. I'd say we keep hex as is while all these changes take place in cubecos.
|
Keeping LMI in cpp related files would be fine since, for CubeCOS, these code in Hex would not take effect. However, |
|
I don't see any harm keeping the behaviors of makehotfixdraft, make hotfix and mountrootfs. The only leftover that users can notice is probably seeing some "LMI" strings when they use hex specific CLI but no big deal. |
|
Got it, would revert the changes. |
2841c3f to
144369d
Compare
…her node drivers through httpd Signed-off-by: Jim Lin <jim.lin@bigstack.co>
This reverts commit c13c669. Signed-off-by: Jim Lin <jim.lin@bigstack.co>
144369d to
2096cf3
Compare
|
@leechienpang We would need at least one approval to merge this PR. |
What type of PR is this?
What this PR does / why we need it
Which issue(s) this PR fixes
Special notes for your reviewer
Additional documentation