Skip to content

Support react v0.14#58

Merged
bhauman merged 2 commits into
bhauman:masterfrom
minimal:react0.14
Oct 17, 2015
Merged

Support react v0.14#58
bhauman merged 2 commits into
bhauman:masterfrom
minimal:react0.14

Conversation

@minimal

@minimal minimal commented Oct 16, 2015

Copy link
Copy Markdown
Contributor

Hi , this adds minimal support for react 0.14 without affecting 0.13 users.

React 0.14 removes React.initializeTouchEvents as it's no longer
needed.

_isReactElement was removed and replaced with the $$typeof field which
contains an ES6 symbol if supported or a number.

Warnings are visible for 0.14 which could be stopped by using ReactDOM for the
render and findDOMNode functions etc.

https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#breaking-changes
react/react#4832

Adds minimal support for react 0.14 without affecting 0.13 users.

React 0.14 removes React.initializeTouchEvents as it's no longer
needed.

_isReactElement was removed and replaced with the $$typeof field which
contains an ES6 symbol if supported or a number.

Warnings are visible for 0.14 which can be stopped by using ReactDOM for
render and findDOMNode etc.

https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#breaking-changes
react/react#4832
Symbol.for causes:

"WARNING - Keywords and reserved words are not allowed as unquoted
property names in older versions of JavaScript."
@minimal

minimal commented Oct 17, 2015

Copy link
Copy Markdown
Contributor Author

You were right, I needed to quote $$typeof for advanced to work (as well as adding another extern for react from here). I also quoted the for attribute as the Closure compiler gave warnings about it. I used aget for consistency although I gather goog.object.get is now the recommended way for getting attributes.

An advanced compiled devcards/om.next/react-0.14 page is at http://minimal.github.io/om-next-tut/#!/om_next_tut.core

bhauman pushed a commit that referenced this pull request Oct 17, 2015
@bhauman
bhauman merged commit 0020fbc into bhauman:master Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants