Skip to content

Remove dead code identified by static analysis#6473

Merged
snejus merged 1 commit intobeetbox:masterfrom
duriantaco:remove-dead-code
Mar 30, 2026
Merged

Remove dead code identified by static analysis#6473
snejus merged 1 commit intobeetbox:masterfrom
duriantaco:remove-dead-code

Conversation

@duriantaco
Copy link
Copy Markdown
Contributor

Hi! Just doing some cleanup..

Description

Remove unused functions, methods, and classes with zero callers, identified by Skylos

Removed:

  • ListenBrainzPlugin.get_weekly_exploration, get_weekly_jams, get_last_weekly_exploration, get_last_weekly_jams: unused convenience wrappers in beetsplug/listenbrainz.py (never called anywhere in the codebase)
  • FtInTitlePlugin.find_bracket_position: unused static method in beetsplug/ftintitle.py
  • submit_albums(): unused standalone function in beetsplug/mbcollection.py (superseded by MBCollection.add_releases())
  • NullPaddedInt: unused class in beets/dbcore/types.py (never imported or instantiated)

0 additions, 38 deletions across 4 files. We ran grep to do a second layer of verification.

To Do

This is a pure dead code cleanup (only deleted unused methods, functions and classes), so we believe documentation, changelog, and tests are not required.

  • Documentation
  • Changelog
  • Tests

@duriantaco duriantaco requested a review from a team as a code owner March 30, 2026 06:15
@github-actions
Copy link
Copy Markdown

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

Copy link
Copy Markdown
Member

@snejus snejus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snejus snejus merged commit 4f54147 into beetbox:master Mar 30, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants