Remove dead code identified by static analysis#6473
Merged
snejus merged 1 commit intobeetbox:masterfrom Mar 30, 2026
Merged
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Just doing some cleanup..
Description
Remove unused functions, methods, and classes with zero callers, identified by Skylos
Removed:
ListenBrainzPlugin.get_weekly_exploration,get_weekly_jams,get_last_weekly_exploration,get_last_weekly_jams: unused convenience wrappers inbeetsplug/listenbrainz.py(never called anywhere in the codebase)FtInTitlePlugin.find_bracket_position: unused static method inbeetsplug/ftintitle.pysubmit_albums(): unused standalone function inbeetsplug/mbcollection.py(superseded byMBCollection.add_releases())NullPaddedInt: unused class inbeets/dbcore/types.py(never imported or instantiated)0 additions, 38 deletions across 4 files. We ran
grepto do a second layer of verification.To Do
This is a pure dead code cleanup (only deleted unused methods, functions and classes), so we believe documentation, changelog, and tests are not required.