Update integration tests for the AOI builder request/result API - #174
Open
sdrichards-bc wants to merge 1 commit into
Open
sdrichards-bc wants to merge 1 commit into
sdrichards-bc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update integration-test AOI construction to use the new
AOIBuilderAPI. The shared AOI fixture and KML reprojection test now create anAOIBuildRequest, callbuild_from_request(), and extract theAreaOfInterestfrom the returned build result.This restores compatibility between integration-test setup and the updated AOI builder, allowing the file pipeline tests to exercise the current application API.
Changes
AOIBuildRequestat both AOI construction sites.AOIRequestand sourceGeoDataFrameinAOIBuildRequest(spec=request, raw_gdf=...).AOIBuilder().build_from_request(build_request).built_aoi.aoiwherever the fixture or pipeline requires anAreaOfInterest.conftest.pyaoifixture to the new builder boundary while continuing to return anAreaOfInterest.test_file_pipeline.pytest_kml_aoi_reprojects()and pass the extracted AOI torun_analysis().Dependency
Requires pr/aoi-builder update that introduces
AOIBuildRequest,build_from_request(), andAOIBuildResult. Merge this after that update, or target its branch while reviewing the changes together.Check List