Skip to content

Feat/spreadsheet args - #170

Open
isaac1345 wants to merge 3 commits into
mainfrom
feat/spreadsheet_args
Open

isaac1345 wants to merge 3 commits into
mainfrom
feat/spreadsheet_args

Conversation

@isaac1345

@isaac1345 isaac1345 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Important

Please provide Summary Request Here. Include:

  1. Reference to the issue #
  2. Description of the changes proposed

This References issue #164 and adds argument parsing.

The following arguments are accepted:
--input, -i: folder containing the xlsx files that need to be converted
--file, -f: The individual xlsx file to convert
--output, -o: The output folder to put the yaml files

Check List

  • Code runs locally
  • Tests pass
  • New behavior has tests
  • Documentation updated if behavior changed
  • No secrets, credentials, or local-only paths committed
  • Logging uses module-level loggers
  • Exceptions and validation results follow engine convention

Other Comments?

@isaac1345

isaac1345 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

I will be testing this a little more extensively, including:

  • Test on folder input/output
  • test on folder with invalid files
  • test on empty folder
  • test on invalid single file
  • test on non-existent folders

@thaynesbc thaynesbc added this to the Data Inventory Engine milestone Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update the spreadsheet conversion to accept path arguments, such as to where we're storing things on the network drive

2 participants