[9.3.0] Improve --execution_log_compact_file= with output service (https://github.com/bazelbuild/bazel/pull/30498) - #30583
Open
Conversation
…zelbuild#30498) Previously since the logging code wasn't aware of output services it would inspect every file for the log info, resulting in downloads of every file. Now we use the output service for this. In my test this took a build from ~10 minutes to ~4 minutes with bb-clientd (based on network quality) Closes bazelbuild#30498. Closes bazelbuild#30509 PiperOrigin-RevId: 956344472 Change-Id: Iaf1e05c59c38d522caca51663d891c4b262bc7a8 (cherry picked from commit 4c0144d)
github-actions
Bot
added
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously since the logging code wasn't aware of output services it
would inspect every file for the log info, resulting in downloads of
every file. Now we use the output service for this. In my test this took
a build from ~10 minutes to ~4 minutes with bb-clientd (based on network quality)
Closes #30498.
Closes #30509
PiperOrigin-RevId: 956344472
Change-Id: Iaf1e05c59c38d522caca51663d891c4b262bc7a8
(cherry picked from commit 4c0144d)