[9.3.0] Stream module lockfiles directly to disk (https://github.com/bazelbuild/bazel/pull/30428) - #30581
Open
bazel-io wants to merge 1 commit into
Open
Conversation
### Description Stream `MODULE.bazel.lock` serialization through a buffered UTF-8 writer instead of building the complete JSON as a `String`. The same helper writes both workspace and hidden lockfiles. Preserve the existing trailing newline and I/O failure logging, and add a regression test for the exact persisted JSON and newline. ### Motivation A real hidden lockfile reached 456,397,262 bytes (435.254 MiB). `Gson.toJson(updatedLockfile) + "\n"` creates two full strings, about 870 MiB of transient heap, and can fail in `BazelLockFileModule.updateLockfile` with `java.lang.OutOfMemoryError: Java heap space`. Streaming Gson directly to disk removes those full-size intermediate strings. ### Build API Changes No ### Checklist - [x] I have added tests for the new use cases (if any). - [x] I have updated the documentation (if applicable). ### Release Notes RELNOTES: None Closes bazelbuild#30428. PiperOrigin-RevId: 955067300 Change-Id: I637f7cb724101d197b6ec64e1eb3081717f7c8e4
bazel-io
added
team-ExternalDeps
iancha1992
enabled auto-merge
August 4, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stream
MODULE.bazel.lockserialization through a buffered UTF-8 writer instead of building the complete JSON as aString. The same helper writes both workspace and hidden lockfiles. Preserve the existing trailing newline and I/O failure logging, and add a regression test for the exact persisted JSON and newline.Motivation
A real hidden lockfile reached 456,397,262 bytes (435.254 MiB).
Gson.toJson(updatedLockfile) + "\n"creates two full strings, about 870 MiB of transient heap, and can fail inBazelLockFileModule.updateLockfilewithjava.lang.OutOfMemoryError: Java heap space.Streaming Gson directly to disk removes those full-size intermediate strings.
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Closes #30428.
PiperOrigin-RevId: 955067300
Change-Id: I637f7cb724101d197b6ec64e1eb3081717f7c8e4
Commit 3206eb9