Skip to content

add static dir for diagram sourcing#1443

Merged
ericbrown99 merged 1 commit into
masterfrom
roethke/fix-fault-diagrams
May 14, 2026
Merged

add static dir for diagram sourcing#1443
ericbrown99 merged 1 commit into
masterfrom
roethke/fix-fault-diagrams

Conversation

@roethke
Copy link
Copy Markdown
Collaborator

@roethke roethke commented May 13, 2026

What changed? Why?
Fixed an issue where diagram/assets weren't being stored resulting in diagrams not rendering.

Notes to reviewers

How has it been tested?
Locally

@roethke roethke requested review from ericbrown99 and youssefea May 13, 2026 20:37
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented May 13, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mintlify
Copy link
Copy Markdown

mintlify Bot commented May 13, 2026

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
base 🟢 Ready View Preview May 13, 2026, 8:39 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@cb-heimdall
Copy link
Copy Markdown
Collaborator

Review Error for ericbrown99 @ 2026-05-14 16:06:27 UTC
User failed mfa authentication, see go/mfa-help

@ericbrown99 ericbrown99 merged commit 5735457 into master May 14, 2026
8 checks passed
@ericbrown99 ericbrown99 deleted the roethke/fix-fault-diagrams branch May 14, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants